bug: hideShortsAppShortcut and hideShortsWidget options are not working

ReVanced / revanced-patches

🧩 Patches for ReVanced

https://revanced.app

GNU General Public License v3.0

2.63k stars 301 forks source link

bug: hideShortsAppShortcut and hideShortsWidget options are not working #3984

Closed rodrigoswz closed 1 day ago

rodrigoswz commented 4 days ago

Bug description

Try to use patcher-args -e 'Hide Shorts components' -OhideShortsAppShortcut=true -OhideShortsWidget=true

YouTube is patched with success, but Shorts is present on app shortcuts and on the widget.

Error logs

Solution

No response

Additional context

No response

Acknowledgements

[x] I have checked all open and closed bug reports and this is not a duplicate.
[x] I have chosen an appropriate title.
[x] All requested information has been provided properly.

LisoUseInAIKyrios commented 4 days ago

@oSumAtrIX I'm not sure what need to change to fix this. Boolean patch options are always false no matter what arguments are used. The string patch options work as expected, but boolean seems broken.

oSumAtrIX commented 3 days ago

The tests pass for the option value parser at least so it may be an issue with how its used. I'll check