search

ReactTraining / react-history

Manage session history with React
266 stars 23 forks source link

Upgraded history to 4.7.2 & react/react-dom to 16.2.0. Changed test f… #24

Closed romellogoodman closed 5 years ago

romellogoodman commented 6 years ago

…uncationality to account for default location creation

romellogoodman commented 6 years ago

CI seems to be failing at the react error for Map at the cases

Mobile Safari 8.0.0 (iOS 8.3.0) ERROR
  TypeError: Map constructor does not accept arguments
  at webpack:///~/react/cjs/react.development.js:1032:0 <- tests.webpack.js:1270
Mobile Safari 8.0.0 (iOS 8.3.0): Executed 0 of 0 ERROR (1.676 secs / 0 secs)

AND

IE 10.0.0 (Windows 8.0.0) ERROR
  'Map' is undefined
  at webpack:///~/react/cjs/react.development.js:1032:0 <- tests.webpack.js:1270
IE 10.0.0 (Windows 8.0.0): Executed 0 of 0 ERROR (1.38 secs / 0 secs)

But according to the Mozilla developer page these versions should be capable of using Map. I'll try to investigate whats going on here. Also worth noting that this error is being thrown by react and not the react-history library.