search

ReactiveCircus / android-emulator-runner

A GitHub Action for installing, configuring and running hardware-accelerated Android Emulators on macOS virtual machines.
Apache License 2.0
977 stars 193 forks source link

Avoid changing the owner of unnecessary files #406

Closed jzbrooks closed 1 month ago

jzbrooks commented 1 month ago

There's probably even more precision to be had, but this seems like a good step forward. This is a different approach to the same problem as #344. I'd be happy to close this in favor of that one!

Source files shouldn't matter for the purposes of this tool. There are a number of files.

 % ls -R $ANDROID_HOME/sources/android-34 | wc -l       
   17750
jzbrooks commented 1 month ago

@ychescale9, any chance the failing test is a flake? It doesn't seem related to this change.

ychescale9 commented 1 month ago

Thanks for the contribution!

Could you please run npm run build and push the changes?

I can reproduce the failing test from main branch so I think there's likely an issue with the latest version of the system image Google released. So probably not much we can do on our end.