search

ReactiveCircus / android-emulator-runner

A GitHub Action for installing, configuring and running hardware-accelerated Android Emulators on macOS virtual machines.
Apache License 2.0
977 stars 193 forks source link

fix(ubuntu): verify command line tools is the version we want #411

Open mikehardy opened 1 month ago

mikehardy commented 1 month ago

Per discussion with @ychescale9 - optionally update the cmdline-tools package if it is not the correct version

Right now there is a difference in the sdkmanager XML versions distributed by servers (v4) and handled by ubuntu-24 runner image pre-installed cmdline-tools sdkmanager (only handles v3), so this is already a problem, and for that reason I set the default to "true" - correctness over performance

But people can toggle it off if they want

mikehardy commented 1 month ago

This quieted down the sdkmanager errors related to XML version 4 being seen but tools only supporting up to version 3

mikehardy commented 1 month ago

I updated this to main and made it so you can disable it with an input boolean, but I believe it is already causing a correctness issue so I left it as default true (correctness >> performance). Ready for review and either adoption or we can close if not interested @ychescale9