ReactiveCircus / android-emulator-runner

A GitHub Action for installing, configuring and running hardware-accelerated Android Emulators on macOS virtual machines.
Apache License 2.0
977 stars 193 forks source link

fix(ubuntu): chown more safely #412

Closed mikehardy closed 1 month ago

mikehardy commented 1 month ago
mikehardy commented 1 month ago

This can be considered a follow-on to #406 - which is a nice performance boost but makes assumptions about the directories existing - linux will throw a non-zero exit code if you chown something that isn't there but using a || true in the shell means that you can blindly try the chown and it's fine if it fails

mikehardy commented 1 month ago

chown not required at all anymore it seems - less code == better

https://github.com/ReactiveCircus/android-emulator-runner/pull/409#discussion_r1796280800