search

ReadieFur / BSDataPuller

Gathers data about the current map you are playing to then be sent out over a websocket for other software to use, e.g. A web overlay like BSDP-Overlay. This mod works with multi PC setups!
https://github.com/ReadieFur/BeatSaber-Overlay
GNU General Public License v3.0
39 stars 10 forks source link

The accuracy value is different from the in-game display. #6

Closed rynan4818 closed 3 years ago

rynan4818 commented 3 years ago

The in-game and HTTPStatus accuracy indications are correct, but the DataPuller is slightly larger.

https://youtu.be/4sb6Hgjc3HY

The maximum score when the total number of notes in the map is 44. 115+(115x2x4)+(115x4x8)+(115x8x(44-13))=33235

32027/33235=0.96365 →96.37%

chenxiaolong commented 3 years ago

My pull request (#5) should have the side effect of fixing this because I updated the code to get maximum score from the ScoreController.immediateMaxPossibleScoreDidChangeEvent event instead of the scoreController.immediateMaxPossibleRawScore field. I'm not sure why immediateMaxPossibleRawScore is slightly larger.

ReadieFur commented 3 years ago

My pull request (#5) should have the side effect of fixing this because I updated the code to get maximum score from the ScoreController.immediateMaxPossibleScoreDidChangeEvent event instead of the scoreController.immediateMaxPossibleRawScore field. I'm not sure why immediateMaxPossibleRawScore is slightly larger.

Yes I've seen your changes, thanks for that @chenxiaolong, I've been aware of this issue but the value difference was so minor that I never bothered to fix it, I have implemented your changes but I won't be releasing an update till I've tweaked a few other things.

chenxiaolong commented 3 years ago

Thank you!