Closed anthony-robin closed 12 months ago
Thank you for the review ! I will have a deeper look to it and will be very happy to increase my skills on React by your reviews and advices :)
Let me check
Update the following cards to take into account currency changed
last 4 commits have are the result of a peer coding with @anthony-robin.
The currency switch is now dynamic and use store
Updated the PR to handle more components currency switch
Pushed an update to the AssetTable
component I missed earlier.
Still need to address Nandy's note about querying too much Gnosis endpoint.
Addressed last Nandy's suggestion by passing rate from the parent to each asset components to avoid too many API calls.
I still have some hydratation issues showing up on the table view, I'm not sure what the issue is...
My most recent commits have:
number | undefined
instead of Number
18.2.25
Fixes #12
Currently, the dashboard only display prices in
$
fiat currency. This PR adds a new option allowing to switch from$
to€
using accurate rate provided by Gnosis API.⚠️ This is a draft PR ⚠️
I made most of changes to handle multiple currencies by my React knowledges are not strong enough for me to make it reactive. For now a page refresh is still necessary to update the price. Feel free to commit to this MR, pushing appropriate changes, and refactor my code if it does not follow the React best practices or rules <3
Co-Authored-By @NandyBa