Red-Studio-Ragnarok / Fancier-Block-Particles

Turn boring particles into fancier particles!
https://www.curseforge.com/minecraft/mc-mods/fbp
GNU General Public License v3.0
10 stars 4 forks source link

[Fancy Block Placement] Rapid placing blocks crash NPE: `at net.minecraft.inventory.Slot.putStack` #14

Open Krutoy242 opened 1 year ago

Krutoy242 commented 1 year ago

Describe the bug

After this issue was fixed, i tested is everything continue working.

When I hold right-click and run, placing Mek Cubes, on moment 6th cube should be placed game crashed.

I tested this issue two times.

dwm_Ga6JsoaWzd

dwm_Gus7sXUhx7

Additional info

Log

java.util.concurrent.ExecutionException: java.lang.NullPointerException
    at java.util.concurrent.FutureTask.report(FutureTask.java:122)
    at java.util.concurrent.FutureTask.get(FutureTask.java:192)
    at net.minecraft.util.Util.runTask(SourceFile:531)
    at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:1088)
    at net.minecraft.client.Minecraft.run(Minecraft.java:6614)
    at net.minecraft.client.main.Main.main(SourceFile:123)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:497)
    at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
    at net.minecraft.launchwrapper.Launch.main(Launch.java:28)
Caused by: java.lang.NullPointerException
    at net.minecraft.inventory.Slot.putStack(Slot.java:70)
    at net.minecraft.inventory.Container.setAll(Container.java:527)
    at net.minecraft.client.network.NetHandlerPlayClient.handleWindowItems(NetHandlerPlayClient.java:1191)
    at net.minecraft.network.play.server.SPacketWindowItems.processPacket(SourceFile:50)
    at net.minecraft.network.play.server.SPacketWindowItems.processPacket(SourceFile:12)
    at net.minecraft.network.PacketThreadUtil$1.run(SourceFile:13)
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
    at java.util.concurrent.FutureTask.run(FutureTask.java:266)
    at net.minecraft.util.Util.runTask(SourceFile:529)
    ... 9 more

debug.log

Desoroxxx commented 1 year ago

Pretty sure mekanism playing with multithreading can you test without FBP if this issue happens

Krutoy242 commented 1 year ago

I tested: without FBP this issue not happen.

Desoroxxx commented 1 year ago

Project: Pacificus Ponens