cpwood
commented
5 years ago Tomas - thank you for your message. Your criticism is noted. We are in the process of changing the code and will release a new version shortly.
We hope you'll continue to find the package useful and continue to benefit from the time we've invested in it.
If you run into problems in the future, why not contribute yourself?
On Wed, 15 May 2019 at 10:10, Tomas Rutkauskas notifications@github.com wrote:
Guys, I cannot believe that I just find out in your source files. You use while loop in ConfigurationManager.Initialise()
Do you know what consequences this cause? The application hangs if no connection to LogDNA or LogDNA server is down like we have today.
You must add retry counts and don't use just pure while infinite loop!
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/RedBearSys/RedBear.LogDNA/issues/4?email_source=notifications&email_token=ADKRWGERXHYJ3VTB534TQQDPVPHQZA5CNFSM4HNBG322YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GT32MNA, or mute the thread https://github.com/notifications/unsubscribe-auth/ADKRWGDX4ERFKMBIYIYXHCLPVPHQZANCNFSM4HNBG32Q .
Guys, I cannot believe that I just find out in your source files. You use while loop in ConfigurationManager.Initialise()
https://github.com/RedBearSys/RedBear.LogDNA/blob/fefe35a2290cadbb56efe5e664bbd473b357acc2/src/LogDNA/ConfigurationManager.cs#L264
Do you know what consequences this cause? The application hangs if no connection to LogDNA or LogDNA server is down like we have today.
You must add retry counts and don't use just pure while infinite loop!