RedHatGov / redhatgov.workshops

This is a collection of Ansible-deployed workshop environments. Use it in combination with the student workbook content, from the repo at https://github.com/RedHatGov/redhatgov.github.io
http://redhatgov.io
64 stars 69 forks source link

bash-completion package not installed on RHEL 8 hosts #164

Closed benblasco closed 2 years ago

benblasco commented 3 years ago

I noticed that bash-completion, which is super useful for attendees, is not installed on the RHEL hosts in the RHEL 8 workshop.

I would be happy to add this function myself but would like some guidance on where you suggest the code be located. I know that most of the work is done by the roles in the redhatgov.workshops/roles directory, but am not sure which would be most suitable to add it to, as I do not want to break any other workshops, or non-RHEL 8 deployments.

The installation is as simple as adding the bash-completion package from the RHEL 8 baseos repo.

benblasco commented 3 years ago

I have committed a change to implement this for the RHEL 8 workshop specifically, via existing PR

https://github.com/RedHatGov/redhatgov.workshops/pull/163

Could you please link this issue to that PR?

Change tested successfully:


[bblasco@bblasco-t490s rhel_aws]$ ansible-playbook 2_load.yml --tags=bash-completion

PLAY [Wait for AWS AMIs to become initialized] *****************************************************************************************

PLAY [Subscribe system] ****************************************************************************************************************

PLAY [Configure epel on nodes] *********************************************************************************************************
[WARNING]: Could not match supplied host pattern, ignoring: le_node

PLAY [Configure repositories on nodes] *************************************************************************************************
skipping: no hosts matched

PLAY [Configure software on nodes] *****************************************************************************************************

TASK [install bash-completion (RHEL 8)] ************************************************************************************************
changed: [rhel.node.5.sandbox60.opentlc.com]
changed: [rhel.node.0.sandbox60.opentlc.com]
changed: [rhel.node.6.sandbox60.opentlc.com]
ok: [rhel.node.9.sandbox60.opentlc.com]
changed: [rhel.node.3.sandbox60.opentlc.com]
changed: [rhel.node.4.sandbox60.opentlc.com]
changed: [rhel.node.7.sandbox60.opentlc.com]
changed: [rhel.node.8.sandbox60.opentlc.com]
changed: [rhel.node.2.sandbox60.opentlc.com]
changed: [rhel.node.1.sandbox60.opentlc.com]
ajacocks commented 2 years ago

Closed by #163