search

RedHatInsights / bonfire

Orchestrates ephemeral environments for testing cloud.redhat.com applications
18 stars 53 forks source link

Bonfire should know it shouldn't keep trying it if can't pull image for iqe-cji pod #190

Open Victoremepunto opened 2 years ago

Victoremepunto commented 2 years ago

bonfire deployment timeout for me, I used the wrong Image tag but that wasn't handled properly by bonfire - I checked and I saw the image pull back off message on openshift - bonfire should be able to handle this and fail the deployment.

bsquizz commented 2 years ago

Let's see if the ImagePullBackoff error appears anywhere in a pod's status conditions (I think it might but need to confirm)

At the moment we check the status conditions for a resource after it times out at this point: https://github.com/RedHatInsights/bonfire/blob/master/bonfire/openshift.py#L687

We could start checking these conditions during the observe call, somewhere in here: https://github.com/RedHatInsights/bonfire/blob/master/bonfire/openshift.py#L610-L619 and fail fast if we see image pull backoff errors on pods.

bsquizz commented 1 year ago

https://github.com/RedHatInsights/ocviapy/pull/9 will help with this