RedHatQE / widgetastic.patternfly

Library of Patternfly widgets for Widgetastic.
Other
13 stars 29 forks source link

fixed the modal test, resolved #126 Issue #128

Open omkarkhatavkar opened 4 years ago

omkarkhatavkar commented 4 years ago

Fixed https://github.com/RedHatQE/widgetastic.patternfly/issues/126

Test Result

========================================================= test session starts ==========================================================
platform linux -- Python 3.7.3, pytest-6.1.2, py-1.9.0, pluggy-0.13.1
cachedir: .tox/py37/.pytest_cache
rootdir: /home/okhatavk/Learning/widgetastic.patternfly
plugins: httpserver-0.3.6, cov-2.10.1, allure-pytest-2.8.19
collected 100 items / 99 deselected / 1 selected                                                                                       

testing/test_modal.py 
-- Docs: https://docs.pytest.org/en/stable/warnings.html
======================================== 1 passed, 99 deselected, 1 warning in 92.26s (0:01:32) ========================================

_

omkarkhatavkar commented 4 years ago

Travis Issue fixed in PR #127

mshriver commented 2 years ago

@omkarkhatavkar keep an eye here: https://github.com/RedHatQE/widgetastic.patternfly/pull/132/files

I added a skip for this test so that I can see all passing, you can remove the skip in your branch if that gets merged before you make an update here. Otherwise I'll remove the skip marker.