RedReign / FoundryVTT-BetterRolls5e

A module for modifying certain sheet functions on Foundry VTT Character sheets for D&D 5th Edition.
GNU General Public License v3.0
36 stars 67 forks source link

Cannot delete chat message after reroll #316

Closed Stewart12 closed 3 years ago

Stewart12 commented 3 years ago

Description After rolling an attack and clicking advantage on that attack, any new chat messages created via the 'Repeat the Roll' button cannot be removed.

Steps to replicate

  1. Make a standard roll with any weapon
  2. Click the + or - to give advantage or disadvantage
  3. Click the 'Repeat the roll' button
    • Note that the newly generated chat message cannot be deleted.

Using FVTT: 0.8.9 DnD5e 1.4.2 Better Rolls 5e 1.6.8

image

Current Workaround Refreshing the page allows the delete option to reappear. Sometimes the previous attack chat message needs to be deleted to have this appear, but does not work without refreshing.

CarlosFdez commented 3 years ago

Anything error messages in the console (F12) when you do this?

Stewart12 commented 3 years ago

No errors at all coming through the console. Forgot to mention that I can replicate it across different browsers.

CarlosFdez commented 3 years ago

Couldn't reproduce locally on the latest 5e version at all. Maybe a module interaction of some sort.

Stewart12 commented 3 years ago

You're right, I went through the arduous task of testing with all different modules and found that it's a module interaction between BRf5e and Plutonium. Both are too good to disable, so I'll live with not being able to delete (small price to pay)

CarlosFdez commented 3 years ago

If its what I think it is, I think there's a setting you can disable in that module that'll make it work.

Stewart12 commented 3 years ago

You're right, disabling the 'Compact Chat' option within Plutonium setting resolved the issue. Cheers for the help!