Conflict between Dice So Nice and Better Rolls 5E when rolling NPC abilities

RedReign / FoundryVTT-BetterRolls5e

A module for modifying certain sheet functions on Foundry VTT Character sheets for D&D 5th Edition.

GNU General Public License v3.0

36 stars 67 forks source link

Conflict between Dice So Nice and Better Rolls 5E when rolling NPC abilities #331

Closed apoapostolov closed 3 years ago

apoapostolov commented 3 years ago

DSN 4.2, BetterRolls5E 1.6.13 When both modules are loaded, roll chat messages are generated but do not show in the chat tab. On reload, they will appear but they do not immediately. Removing one of the mods fixes the behavior.

JiDW commented 3 years ago

Hey, DsN dev here. I've tracked the issue to this line in custom-rolls:

roll: new Roll("0").roll()

I'm adding a protection in DsN to deal with this kind of "NumericTerm"-only rolls

jegasus commented 3 years ago

In my world, this also seems to affect player characters too.

JiDW commented 3 years ago

In my world, this also seems to affect player characters too.

Update to the latest DsN version, it has been fixed

CarlosFdez commented 3 years ago

@JiDW thanks for this! Unfortunately this is a weirdness BR does because 5e hijacks the styling based on the roll result. And also because of delayed rolls when the damage button is turned on....