RedSiege / EyeWitness

EyeWitness is designed to take screenshots of websites, provide some server header info, and identify default credentials if possible.
https://www.christophertruncer.com/eyewitness-usage-guide/
GNU General Public License v3.0
5.01k stars 848 forks source link

Simplfy setup of geckodriver #635

Closed digininja closed 6 months ago

digininja commented 10 months ago

In the Python setup script, you specify the two different architecture paths for the gecko driver at the top and then in each OS block chose which architecture to go with and then install it. What you could do is have a block like this at the top of the script so it is ran for every OS:

if [ ${MACHINE_TYPE} == 'x86_64' ]; then
  wget ${geckodriver_x86_64} -O geckodriver.tar.gz
else
  wget ${geckodriver_x86_32} -O geckodriver.tar.gz
fi

Then in the blocks you can get rid of the architecture checks and just install geckodriver.tar.gz. It would save having to update the version number in loads of places when you update the version.

0x6d6f7468 commented 10 months ago

This is something I'm working on addressing as part of a wider setup.sh rewrite/refactor, also including support for aarch64.

0x6d6f7468 commented 10 months ago

As promised (for once)