RedSiege / EyeWitness

EyeWitness is designed to take screenshots of websites, provide some server header info, and identify default credentials if possible.
https://www.christophertruncer.com/eyewitness-usage-guide/
GNU General Public License v3.0
5.01k stars 848 forks source link

report generation - include screenshot even if website data cannot be gathered #671

Open Relkci opened 5 months ago

Relkci commented 5 months ago

OS Used - ALL Information (architecture, linux flavor, etc.)

Pastebin link to error you are encountering

Expected behavior (vs. what you encountered)

A screenshot should always be included in the report if it exists, even if urllib was unable to capture data.

If a screenshot is created for a website (selenium), but EyeWitness failed to gather information about the website (urllib), the screenshot should be included in the report. Currently, certain exceptions on urllib create conditions where the generated report where a website with a properly generated screenshot is reported as having errored and the screenshot is not included in the report.

Any additional information

some code for this condition already exists on the timeout handling in report generation -- where the report screenshot is included if it exists but urllib failed on timeout. New error handling on urllib calls may cause similar conditions on other errors. the report generation should be updated to always show a report if it exists, even if urllib failed for any reason.