Redot-Engine / redot-engine

Redot Engine – Multi-platform 2D and 3D game engine
https://redotengine.org/
MIT License
4.83k stars 221 forks source link

[4.3] Fix `ColorPicker` overbright indicator position #803

Closed Spartan322 closed 1 month ago

Spartan322 commented 1 month ago

(cherry picked from commit blazium-engine/blazium@f7c6762df94867d93465612ec6be86b28593dc47)

Captain-Wet-Beard commented 1 month ago

Verified on Github image

Spartan322 commented 1 month ago

@Captain-Wet-Beard How about you read https://github.com/godotengine/godot/blob/master/AUTHORS.md and https://github.com/Redot-Engine/redot-engine/blob/master/REDOT_AUTHORS.md first, its pretty explicitly clear that neither represent copyright, and the license is still MIT, only the git blame is covered under copyright and he is credited.

Captain-Wet-Beard commented 1 month ago

the license is still MIT

Since your PR admits youre cherrypicking Blazium PRs, are you planning to add a line to your copy of the MIT license for Blazium contributors?

Spartan322 commented 1 month ago

No, first our LICENSE.txt will not change, secondly it there was no copyright for blazium when the commit was made, even in future cherry-picks its not actually required if the commit makes proper reference to the repo at the time it was cherry-picked which it does regardless. If community people really cared about it, the segments can be commented with the license/repo reference, but that's already fairly excessive anyway. And any modifications done by Redot contributors that overrides the hunks would immediately remove the license anyway.

LokiFawkes commented 1 month ago

Whales is in the AUTHORS.md file, so clearly author credit is not the issue. Seems like Blazium just wants attention.

Captain-Wet-Beard commented 1 month ago

Whales is in the AUTHORS.md file, so clearly author credit is not the issue.

I must have missed where AUTHORS.md is mentioned in the wording of the MIT license.

I was just pointing out a potential copyright problem out of friendly concern, it really doesn't effect me one way or the other if you choose to play fast and loose with licenses.

Feel free to interpret my good faith concern in any way you wish, like I said it isnt my problem.