ReikaKalseki / Reika_Mods_Issues

The issue tracker for all of my mods - RotaryCraft, its addons, ChromatiCraft, and everything else.
46 stars 14 forks source link

Rotarycraft Improve localization #52

Open Adaptivity opened 9 years ago

Adaptivity commented 9 years ago

A lot of localization in rotarycraft is hardcoded: 1) Creative tabs (Mod ores, RotaryCraft Tools etc) 2) Tooltips (Fuel, No fuel, mB of, Spawns and many much more) 3) NEI localization hardcoded (Machine names, dupe chance and etc) 4) All mod ores dusts, flakes, solutions are hardcoded (I know that they are probably automatically generated but they still should be translatable) Few examples how to localize automatically generated names: 1) AOBD: first and second 2) BCA 3) MoreChisels

Also, @ReikaKalseki would be cool if you can add Russian localization for Electricraft from here and update Rotarycraft localization from here

ReikaKalseki commented 9 years ago

A lot of the strings are not easily localized, as they are concatenated from things like "Duplication chance: "+getRareDupeChance()+" per block", which translations are not going to be able to handle due to it being split.

Adaptivity commented 9 years ago

StatCollector.translateToLocal(rotarycraft.dupechance) plus %s tag. The .lang entry will look like: Duplication chance: %s per block I don't know how to properly add %s but this is an easy task. You can check BCA code as an example or any open source mod which have full localization support.

ReikaKalseki commented 9 years ago

I did that with my XML files, but the problem is that not all structures are so easily inserted, and often localized files omit or damage the tags, leading to crashes.

Mrkwtkr commented 9 years ago

If the manual of Rotarycraft can support localization, (like Tinker's Construct and Mariculture?) that will help a lot. Thanks

ReikaKalseki commented 9 years ago

It can - simply make a copy and put it in a subfolder titled "xx_AA" like en_US or fr_QU - but be careful not to damage the %s, %d, and other placeholders.

Of course, I will need the files in order to distribute them.

ReikaKalseki commented 8 years ago

Any news, half a year later?

Adaptivity commented 8 years ago

What kind of news do you need? As I can see, all localization I mentioned still hardcoded and no progress was made to move it out of code. Say me how I can help you.

ReikaKalseki commented 8 years ago

That was more for @Mrkwtkr, who seemed to be intending to translate the handbook.

Adaptivity commented 8 years ago

I guess he retired from MC translations. Also, can you update Russian localization in Rotarycraft and add one for Electricraft? They are available in my first post. And do you plan to work on moving out hardcoded localization?

Mrkwtkr commented 8 years ago

Temporarily retired. I'll be back in the winter holiday. (College life is really tough and keeps me busy, especially before the exam.)

ReikaKalseki commented 8 years ago

Also, can you update Russian localization in Rotarycraft and add one for Electricraft?

I already did that for v10.

Adaptivity commented 8 years ago

Good to know, thanks! Still, what about hardcoded localization?

ReikaKalseki commented 8 years ago

A huge amount of work that has largely been put off in favor of completing CC.