search

Renmusxd / RustQIP

Quantum computing using rust. Efficient and a borrow-checked no cloning theorem!
https://docs.rs/qip/
MIT License
229 stars 18 forks source link

added Rx, Ry and Rz gates #18

Closed atwupack closed 4 years ago

atwupack commented 4 years ago

Hi, I needed the Rx gate for an example and noticed that the three rotational gates Rx, Ry and Rz are currently missing. So, I added them to the builder. I have only tested the Rx gate. Please check if they are all correct.

André

atwupack commented 4 years ago

I am currently replacing some of the existing code with the new gates. This PR should stay open until this has been completed.

atwupack commented 4 years ago

This should be it. The PR is now ready if you want to merge it.

Renmusxd commented 4 years ago

Great, I should be able to check this out on Saturday and merge it in. Thanks for the help!

Renmusxd commented 4 years ago

Using the gates in the teleport test seems like a good test to me, it's just reusing the existing real_mat operation with pauli matrices. I don't think additional unit tests are necessary. Thanks!