search

RensAlthuis / vertical-overview

Gnome has had vertically stacked workspaces for a long time. The Gnome 40 update unfortunately made the switch to a horizontal layout. A choice that many Gnome users disagree with. This extension completely replaces the new Gnome overview with something that resembles the old style.
GNU General Public License v3.0
311 stars 30 forks source link

Fix gnome 41.3 & 42 (pop & ubuntu 22.04) #101

Closed 13r0ck closed 2 years ago

13r0ck commented 2 years ago

Up-streamed by system76 https://github.com/pop-os/cosmic-workspaces/pull/51

Gronkdalonka commented 2 years ago

This fix does work on Gnome 41.4 (Debian bookworm)

atd commented 2 years ago

Thank you for this :heart:

jm-duke commented 2 years ago

The fix is not complete, as it crashes the extension, when e.g. the lock screen activates:

gnome-shell[2341]: JS ERROR: Extension vertical-overview@RensAlthuis.github.com: TypeError: WorkspacesView.SecondaryMonitorD isplay is undefined#012reset@

The reset() method still references WorkspacesView.SecondaryMonitorDisplay, which is no longer there. Removing this reference seems to work fine, no more crashes on my end.

@@ -26,7 +23,6 @@ function override() {

 function reset() {
     Util.overrideProto(WorkspacesView.WorkspacesView.prototype, global.vertical_overview.GSFunctions['WorkspacesView']);
-    Util.overrideProto(WorkspacesView.SecondaryMonitorDisplay.prototype, global.vertical_overview.GSFunctions['SecondaryMonitorDisplay']);
     if (global.vertical_overview.default_old_style_enabled) {
         Main.overview._overview._controls._workspacesDisplay.remove_style_class_name("vertical-overview");
     }
13r0ck commented 2 years ago

This has been change to hopefully fix https://github.com/RensAlthuis/vertical-overview/pull/101#issuecomment-1083059270 & https://github.com/RensAlthuis/vertical-overview/issues/98#issuecomment-1084227148

thankjura commented 2 years ago

After apply this patch and modify metadata.js(for support gnome 42) I have bug:

Screenshot: ![image](https://user-images.githubusercontent.com/2144212/161112266-bf908c0a-74cb-4cee-b745-11b179646a15.png)

Update: revert overviewControls.js fixed this issue

Screenshot: ![image](https://user-images.githubusercontent.com/2144212/161114357-d6a970e6-e097-4263-af5d-932a98c3ec77.png)
neclimdul commented 2 years ago

manually installing this and getting my mental desktop management back in the groove today was the highlight of my morning. thanks for all the work y'all.

axxapy commented 2 years ago

@RensAlthuis This PR was merged but issue described in https://github.com/RensAlthuis/vertical-overview/pull/101#issuecomment-1084872250 is still there. Only way to fix: git checkout 02bf3c4a646037ad65423a23d728108bcc9a892a -- overviewControls.js