RensAlthuis / vertical-overview

Gnome has had vertically stacked workspaces for a long time. The Gnome 40 update unfortunately made the switch to a horizontal layout. A choice that many Gnome users disagree with. This extension completely replaces the new Gnome overview with something that resembles the old style.
GNU General Public License v3.0
311 stars 30 forks source link

fadeInDesktop/fadeOutDesktop removed in gnome-shell 42+ #103

Closed colingibbs1 closed 2 years ago

colingibbs1 commented 2 years ago

See gnome-shell commit here: https://gitlab.gnome.org/GNOME/gnome-shell/-/commit/2127222b39c763d2f018ecd03e4d6abdc995d1b0

This causes JS ERROR: TypeError: Main.overview.fadeInDesktop is not a function

Along with the fixes from #101 this works with gnome-shell 42.0-2 in debian sid.

diff --git a/overviewControls.js b/overviewControls.js
index 77a2a67..19c5a46 100644
--- a/overviewControls.js
+++ b/overviewControls.js
@@ -337,8 +337,6 @@ var ControlsManagerOverride = {

         this._searchController.prepareToEnterOverview();
         this._workspacesDisplay.prepareToEnterOverview();
-        if (!this._workspacesDisplay.activeWorkspaceHasMaximizedWindows())
-            Main.overview.fadeOutDesktop();

         this._stateAdjustment.value = ControlsState.HIDDEN;

@@ -369,8 +367,6 @@ var ControlsManagerOverride = {
         this._ignoreShowAppsButtonToggle = true;

         this._workspacesDisplay.prepareToLeaveOverview();
-        if (!this._workspacesDisplay.activeWorkspaceHasMaximizedWindows())
-            Main.overview.fadeInDesktop();

         this._stateAdjustment.ease(ControlsState.HIDDEN, {
             duration: Overview.ANIMATION_TIME,
wlayher commented 2 years ago

Yes, thank you. This works for me as well on debian sid.

jfernandz commented 2 years ago

The patch also works for gnome-shell 1:42.1-1 in Arch Linux. But sure, it must be applied over 564dc75 :wink: thank you @colingibbs1

RensAlthuis commented 2 years ago

This should be fixed now