search

RequestPolicyContinued / requestpolicy

a web browser extension that gives you control over cross-site requests. Available for XUL/XPCOM-based browsers.
https://github.com/RequestPolicyContinued/requestpolicy/wiki
Other
252 stars 35 forks source link

RPC config screens (about:requestpolicy) unusable with dark system colours #878

Open kenyoni opened 6 years ago

kenyoni commented 6 years ago

Browser

Name: Firefox Version: 56.0.2 Build ID: 20171027085204 User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0

Extensions

Name: RequestPolicy Continued Version: 1.0.beta13.2.1876.r489ddf49.pre Enabled: true Name: Session Manager Version: 0.8.1.13 Enabled: true Name: Tab Mix Plus Version: 0.5.0.4 Enabled: true Name: Text Contrast for Dark Themes Version: 2.0.0 Enabled: true Name: Tree Style Tab Version: 0.19.2017090601 Enabled: true Name: uBlock Origin Version: 1.14.20 Enabled: true Name: YouTube™ No Buffer (Stop Auto-playing) Version: 0.2.6 Enabled: true Name: Firefox Lightbeam Version: 2.0.4 Enabled: false Name: Ghostery Version: 8.0.0.34 Enabled: false Name: Google Scholar Button Version: 2.0 Enabled: false Name: HTTPS Everywhere Version: 2017.12.6 Enabled: false Name: Modify Header Value (HTTP Headers) Version: 0.1.3 Enabled: false Name: Open in VLC media player Version: 0.1.5 Enabled: false Name: Rotate and Zoom Image Version: 1.4 Enabled: false Name: Tab Session Manager Version: 1.7.1 Enabled: false Name: User Agent Switcher Version: 1.1.2 Enabled: false Name: YouTube™ auto Pause and Resume Version: 0.1.1 Enabled: false

Steps to reproduce:

Load a dark system theme (linux, maybe other OS's too) and go to about:requestpolicy

What happens?

White text on white background, dark text on dark background.

What should happen?

All text should be readable. For text boxes, assumptions about the default text and background colours should not be made. if one is set, then the other should be set also. The extension "Text Contrast for Dark Themes" deals with this for most web sites that don't follow the rules, but firefox does not allow the changing of fonts and colours for internal pages such as "about:" pages.

The colours can be made readable using the "Colours" setting in firefox, but this messes up colours on all pages.

myrdd commented 6 years ago

Hi @kenyoni, I'm not sure if it's really caused by the system setting. Maybe the "Text Contrast for Dark Themes" extension influences the colors on "about:requestpolicy" as well?

Could you please provide a screenshot?