ResoniteModdingGroup / MonkeyLoader.GamePacks.Resonite

MonkeyLoader Game Pack which provides hooks for Resonite mods.
https://resonitemoddinggroup.github.io/MonkeyLoader.GamePacks.Resonite/
GNU Lesser General Public License v3.0
14 stars 2 forks source link

Override OnShutdown in ResoniteEventHandlers #42

Closed Nytra closed 2 months ago

Nytra commented 2 months ago

Closes #41 maybe?

Banane9 commented 2 months ago

Hmmmm, what's with the extra commits in the PR? 🤔

Also please add the documentation as well - ideally "Unregisters" could link to the right Mod.UnregisterEventHandler method:

        /// <remarks>
        /// <i>By default:</i> Unregisters this monkey as an event handler for <typeparamref name="TEvent">s
        /// and removes all <see cref="HarmonyLib.Harmony"/> patches done
        /// using this Monkey's <see cref="Harmony">Harmony</see> instance,
        /// if not exiting, and returns <c>true</c>.
        /// </remarks>
        /// <inheritdoc/>
Nytra commented 2 months ago

Those extra commits are just leftovers in my branch and I don't know how to get rid of them :P They don't contain any changes.

Or rather the changes from them are cancelled out

Banane9 commented 2 months ago

Hmmm, not sure, I've had that happen before too, I think.

You can push your changes right to this repository too though, if you want.

Nytra commented 2 months ago

Yeah I probably should do that in the future