search

RestCode / WebApiProxy

MIT License
199 stars 91 forks source link

Make DateTime parameters culture invariant #100

Closed nillis closed 8 years ago

nillis commented 8 years ago

For DateTime parameters the default ToString will look into the CurrentCulture to determine the dateformat. This pull request fixes this with the solution proposed in #70 by @wolfen351.

onionhammer commented 8 years ago

This was already done with a commit I made a while ago, but undone. It might be beneficial to fix the botched merge of all my code by @faniereynders

faniereynders commented 8 years ago

I had to merge plenty of PRs at the time and had to manually resolve the conflicts. This led to possible feature loss. Hopefully things will start to stabilize now.

faniereynders commented 8 years ago

Thanks @nillis for your contribution!

nillis commented 8 years ago

Thanks to you for the fast response! And for the great library I've been using for 6 months now.

faniereynders commented 8 years ago

@nillis if you're interested in helping out as an official contributor, let me know. Would be great to expand on the core team.

ngm commented 8 years ago

Unfortunately this does not seem to work with Nullable<DateTime> - see #112 .