search

RestComm / jss7

RestComm Java SS7 Stack and Services
http://www.restcomm.com/
GNU Affero General Public License v3.0
177 stars 218 forks source link

Sccp conn establishment, release, reset with fixes #252

Closed vmykhailiuk closed 7 years ago

vetss commented 7 years ago

@vmykhailiuk

I am getting confusing in your PRs... which one should I use ? (This PR is also based on master branch)

vmykhailiuk commented 7 years ago

@vetss Creating pull request based on sccp-co branch won't help much because Github will display "Can’t automatically merge.". Most likely it's because sccp-co was created by cherry-picking commits from sccp-conn-establishment-release-#242 branch. I also answered in https://github.com/RestComm/jss7/pull/251 with exact list of commands which will load latest changes to sccp-co branch.

Actually I'm slightly confused too. :) Now it's so much harder than when we had just a master branch, one pull-request with 1 or 2 commits to merge and new pull request was created only after previous one was merged. Also all discussion was in the issue https://github.com/RestComm/jss7/issues/242. Having most of the changes in connection class and keeping routing and stack methods changes at minimum should help with avoiding introducing bugs to connectionless protocol classes implementation.

vetss commented 7 years ago

@vmykhailiuk

may be you can provide some branch in your repo that contains your commits (and give me a commit list) so I can add them into "sccp-co" branch and then you will be able synch to it. Is it possible ?