search

RestComm / jss7

RestComm Java SS7 Stack and Services
http://www.restcomm.com/
GNU Affero General Public License v3.0
177 stars 218 forks source link

Issue-276: M3UA silently hides transmission exception #277

Closed okulikov closed 6 years ago

okulikov commented 6 years ago

This PR replaces silent exit on IOException throwing

gsaslis commented 6 years ago

@okulikov thanks for contributing this! 👍

I've just added this contribution as well next to your name in our Contributors Hall of Fame 👏 . I do see however that the way this was incorporated into our codebase, your name doesn't come up as one of our contributors. If you would like to open another PR so that we can merge this in properly, we'd be more than happy to do that.

On the other hand, I appreciate that you may have moved on, and can't bother with all this, so ... either way... just let me know ;)

okulikov commented 6 years ago

@gsaslis thanks for the notice.

Unfortunately the entry you added to your Contributors Hall of Fame seems a bit not accurate. Can you please remove it?

gsaslis commented 6 years ago

Thanks for getting back to me @okulikov

Sorry, looks like I might have missed something - what's not accurate about it?

okulikov commented 6 years ago

@gsaslis well, I think you did publish very limited list of contributions, so I would prefer to stay in obscurity.

gsaslis commented 6 years ago

@okulikov if you would like to be removed from the list, that's absolutely fine!

However, to be clear, all I did now was to add this single contribution to the list. There was only one before that. If you're implying that there should have been more, I'd be more than happy to look into that for you and have it amended!! (I'm new around here so there might be some history I'm missing...)

Just let me know which way you'd like to go with this plz.

okulikov commented 6 years ago

@gsaslis I appreciate your disturbance about contributors. To be short, I will be fine with automatic and public reference made by git (if it will fail due to some accidental merges not an issue for me) and I would like to be removed from the list. Thanks.

gsaslis commented 6 years ago

@okulikov ok done.

We'll try to make sure future git merges ensure proper attribution. Thanks for your understanding and - of course - for all your contributions. :) 👍