RestComm / media-core

RMS - Restcomm Media Server for Real Time Cloud Communications
http://www.restcomm.com/
GNU Affero General Public License v3.0
160 stars 123 forks source link

Confirm java bitwise shift is supporting RFC #180

Open jaimecasero opened 8 years ago

jaimecasero commented 8 years ago

https://github.com/RestComm/mediaserver/blob/master/io/rtp/src/main/java/org/mobicents/media/server/impl/rtp/JitterBuffer.java#L143

this code is using Java ">>" which use sign bit for filling. The RFC may be refering to normal shift where "0" is used for filling. In that case java code must use ">>>"

jaimecasero commented 8 years ago

http://tools.ietf.org/html/rfc3550#appendix-A.8

Sample C code implementing same logic https://github.com/traviscross/mtr/blob/master/net.c#L847