search

RestComm / sip-servlets

Leading SIP - IMS - WebRTC Application Server
http://www.restcomm.com/
GNU Affero General Public License v3.0
240 stars 181 forks source link

Restcomm/Restcomm-connect#789 Configurable Timer Service Pool Size #186

Closed xhoaluu closed 8 years ago

xhoaluu commented 8 years ago

@jaimecasero

I have updated the code to make a configurable timer service pool size. Please help me to review and give me comments

jaimecasero commented 8 years ago

Have you tested the change on deployed app? Have you considered adding a testcase?

xhoaluu commented 8 years ago

I have not tested it yet. Will spend time to test it

Could you explain the test scenario that we consider to add to sip-servlet test suite? Does Our test case framework support to generate a lot SIP messages to test this enhancement ?

xhoaluu commented 8 years ago

@jaimecasero

I have updated the code, ran debug and could see that the DefaultProxyTimerService was initiated with configured pool size. I also ran the testsuite, and the result was good, there were some failing testcases but I have run it on main branch of restcomm, the results were the same as results on my branch.

jaimecasero commented 8 years ago

@xhoaluu can you add javadoc comments into the new methods so you explain the main differences to reader. Like: initInitalComponents-> prepare basic servlet context atts before the underlying context is actually ready. prepareServletContext -> prepare the rest of the context, when underlying context is ready (ie init params maybe queried)

Also, it would be great, if you could create another PR with aggregated changes in single commit, so the porting to commercial is easier.