search

RestExpress / HyperExpress

Media type agnostic library for producing and consuming hypermedia links (ala. HATEOAS) within RESTful services...
Apache License 2.0
24 stars 14 forks source link

Incompatible with Groovy #5

Open th3morg opened 10 years ago

th3morg commented 10 years ago

I really like your approach here and especially wanted to make use of your HAL Jackson serialization project. However, I'm using groovy and the "setProperty" method in your Resource/AbstractResource conflict with the GroovyObject. I get the following error:

The return type of com.strategicgains.hyperexpress.domain.Resource setProperty(java.lang.String, java.lang.Object) in com.strategicgains.hyperexpress.domain.AbstractResource is incompatible with void in groovy.lang.GroovyObject

If you could make the naming of methods more compatible with Groovy it would be of great benefit. Thank you!

tfredrich commented 9 years ago

That is an interesting problem. I can work that in over time after deprecating the current methods for a bit. But it might be a while...

th3morg commented 9 years ago

Todd, this is something that I might undertake if you are willing to have a look at a pull request.

On Nov 17, 2014, at 7:34 PM, Todd Fredrich notifications@github.com wrote:

That is an interesting problem. I can work that in over time after deprecating the current methods for a bit. But it might be a while...

— Reply to this email directly or view it on GitHub.

tfredrich commented 9 years ago

Pull-request away! :-)

tfredrich commented 9 years ago

BTW, what should that method be named? If I call it 'property(Object)' and the corresponding 'Object property()' getter, will that work? Can I add those new methods or do I have to actually rename the old one?