RetroAchievements / RAIntegration

The DLL responsible to integrate emulators with RetroAchievements.org
https://retroachievements.org
MIT License
97 stars 23 forks source link

Line-Breaks in Code Notes wrongly translated in Emulator #995

Closed SporyTike closed 1 year ago

SporyTike commented 1 year ago

With the new feature to edit code notes on site, there seems to be a small issue with the code note field translating simple line breaks (Enter) wrong when the last edit was made from the site.

Since I have no actual explanation why it's happening, I include some screenshots explaining the problem.

Code note on address 0x3D906A made in the emulator: image

Full note on the website's code note page: image

Editing the code note via website (here I changed Bit2 to Bit0) and press save. Website still looks fine: image

Loading the game in the emulator and checking the code note for address 0x3D906A: image

Important to mention is that the line breaks still exist in the code note, just isn't working in the code note editor editor field. You can still see the line breaks in the code note filter, doing an edit and saving again still shows the line break on the website and if you edit the code note you can "remove" invisible characters where the line breaks originally were.

wescopeland commented 1 year ago

Resolved in the web UI by https://github.com/RetroAchievements/RAWeb/pull/1488

Jamiras commented 1 year ago

Fixed by #996