search

ReviewNB / treon

Easy to use test framework for Jupyter Notebooks
https://reviewnb.com
MIT License
305 stars 29 forks source link

Set working directory to the folder containing the notebook (fixes #12) #14

Closed f4lco closed 5 years ago

f4lco commented 5 years ago

As per discussion in #12, and this comment, treon should have the same behavior as Jupyter, and use the notebooks' folder as working directory. This fixes priorly broken notebook-relative Python imports, and notebooks trying to read resources / data using notebook-relative file paths, in case the working directory of invoking treon did not match the directory containing the notebook.

review-notebook-app[bot] commented 5 years ago

Check out this pull request on ReviewNB: https://app.reviewnb.com/ReviewNB/treon/pull/14

You'll be able to see notebook diffs and discuss changes. Powered by ReviewNB.

amit1rrr commented 5 years ago

Looks good @f4lco

Thanks for adding in the test :)