search

Revivius / nb-darcula

Darcula LAF for NetBeans
281 stars 83 forks source link

Any reason to use the AlexFalappa JAR? #162

Open emilianbold opened 5 years ago

emilianbold commented 5 years ago

It's unclear to me where the darcula JAR used comes from.

From looking at the alexfalappa and bulenkov Darcula repositories they seem about identical except with a minor difference.

I would also suggest that perhaps we could include the Darcula source tree inside here too.

wltjr commented 5 years ago

I believe the jar in use is bulenkov/Darcula, the other AlexFalappa/darcula is a fork of the former. I packaged the former for use with this plugin.

emilianbold commented 5 years ago

@wltjr the JAR use is not from bulenkov/Darcula, see the JAR history.

I guess for Gentoo you only care about the source? I also think including the Darcula source tree directly in nb-darcula might be a good idea.

AlexFalappa commented 5 years ago

@emilianbold my forked version was used because @bulenkov was a bit slow in merging my PRs (14, 15, 18) into the upstream Darcula source tree.

They have been merged since then thus I can safely assume the forked jar is not needed anymore, just try to upgrade to a more recent Darcula release.

I am not really convinced about including a patched Darcula into nb-darcula is the way to go, I would prefer having a forked Darcula github repo because it could be useful on it's own for devs wanting to use the Look and Feel in their own Swing applications (not based on NetBeans RCP)

wltjr commented 5 years ago

@emilianbold I missed that, thanks for pointing it out! Yes I mostly care about the source, but also how it performs. I can always switch repos I am using for the package.