search

Ribbit-Network / ribbit-network-frog-hardware

The sensor for the world's largest crowdsourced network of open-source, low-cost, GHG Gas Detection Sensors.
https://www.ribbitnetwork.org/
MIT License
94 stars 26 forks source link

Fixing Broken Link related to issue #154 #155

Closed eaudiffred closed 1 year ago

eaudiffred commented 1 year ago

Broken links to international BOMs in V2 and V3. Issue #154. This fixes the first part of the problem stated in the issue.

eaudiffred commented 1 year ago

To correct the broken links I just routed back to the V1 folder with the V1 international BOMs. Now that I think about it, that may not be the best idea, as it could get confusing if you are trying to build V3, but then get directed back to a V1 folder. @keenanjohnson, let me know what you think. Maybe it would be better to leave the link dead until we create the V3 specific international BOM.

keenanjohnson commented 1 year ago

Hmmmmm yeah I would hate for someone to purchase old parts because they didn't read through the description too well. perhaps we could just add a note that we have previously had international BOMs and we are looking for volunteers to localize them?

eaudiffred commented 1 year ago

I went ahead and added an international_boms folder to V2 and V3. I also added a little text asking for help creating them.

keenanjohnson commented 1 year ago

Perfect! Thanks!

eaudiffred commented 1 year ago

@keenanjohnson, is there something I can do to make these reviews/approvals easier? I know you are hyper focused on the software development right now and I don't want to add extra work to your plate!

keenanjohnson commented 1 year ago

Thanks @eaudiffred ! I think these are pretty straight forward for me, and you are being so helpful in other ways, so no worries.