search

Rightpoint / RZVinyl

Stack management, ActiveRecord utilities, and seamless importing for Core Data
Other
21 stars 6 forks source link

Remove Protocols #66

Closed KingOfBrian closed 8 years ago

KingOfBrian commented 8 years ago

This PR removes the 2 protocols that were added in #45 for swift support that I don't think are actually needed for swift support. The pattern of implementing a category in a framework and then over-riding in subclasses seems to be best practice, so I'm not sure that it's helping us at all, and it's a bit obscure as to why it's needed.

I was getting reading to make a 1.2 release, and noticed that this change never made it out into an official release, so I thought if we could get consensus that this isn't needed we could remove it before it made it out into a supported version.

@jwatson / @nbonatsakis / @mgorbach / @dostrander / @cmds4410 -- If you have a swift project using RZVinyl, can you point your pod to this branch and see if you have any issues?

jwatson commented 8 years ago

@KingOfBrian no issues in my project.