Rightpoint / android-template

A `cookiecutter` template for Android projects
28 stars 4 forks source link

Various project configuration changes #46

Closed jonduran3000 closed 5 years ago

jonduran3000 commented 5 years ago
Drufyre commented 5 years ago

@octohub @arjunvekariyagithub So in talking with Jon, the thought process behind removing many of the dimensions and styles that were present was that these should follow the Material Design Spec. Additionally, the non-text dimensions that were removed do not inherently convey their purpose in their naming, which would hinder what flexibility you might get from them (someone using dp_single as a margin in one place, and as the radius for rounded corners otherwise, would have rippling side effects if the value of dp_single ever changed, for example).

The resource values that were removed really more project-specific and it's the responsibility of the developer on that project to put them in place should they be needed. The remaining resources are considered a minimum baseline from which someone could customize on top of. Happy to talk further on this.

jonduran3000 commented 5 years ago

To add on here, there's effectively no difference between hardcoding 8dp and using the dp_single dimension in your layouts. For example:

If we build multiple card layouts using dp_single as the margins and design comes back and says they want all card margins to be 16dp instead, then we are probably just going to go in and refactor every single card layout as opposed to changing the value of dp_single. Changing the value behind the dimension would cause rippling side effects like Jason suggested.