search

Rightpoint / android-template

A `cookiecutter` template for Android projects
28 stars 4 forks source link

[WIP] Custom Lint: TODO #59

Closed k-thryn closed 5 years ago

k-thryn commented 5 years ago

This is a complete custom Lint implementation with passing tests - there are still some issues getting the ./gradlew lintDebug task to actually run the rule, so someone else may need to pick up the torch there unfortunately since today is my last day.

Here is a great resource on custom Lint, hopefully it will help get this across the finish line!

octohub commented 5 years ago

@jonduran3000 Will this cause the build to fail if these lint checks don't pass? And will the results be outputted to an html file in the artifacts of the build?

jonduran3000 commented 5 years ago

Right now the only custom lint check is set to a warning severity so it won't fail the build. That severity can be modified as needed though. As far as outputs, the lint HTML reports be added as an artifact to the build but if you have a Github token set on your project it will get detected by the Danger bot and a comment will be made on your pull request.