RiotGames / key-conjurer

Temporary Credential Service
https://technology.riotgames.com/news/key-conjurer-our-policy-least-privilege
Apache License 2.0
167 stars 33 forks source link

Better error handling on the backend side #72

Closed artem-smotrakov closed 2 years ago

artem-smotrakov commented 2 years ago

Currently, the backend returns "internal server error" even if there was not actually a problem on the server side. This PR tries to improve error handling in KeyConjurer so that a user gets more info in errors returned by KeyConjurere.

Main updates:

artem-smotrakov commented 2 years ago

Thanks for the review @trinitroglycerin ! The comments make sense to me. In fact, there are a few more functions that should not be exported. I've addressed your comments.