search

Riverscapes / QRAVEPlugin

QGIS Plugin for viewing Riverscapes projects
GNU General Public License v3.0
0 stars 0 forks source link

Duplicate names of layers from export cant be viewed simultaneously in viewer #126

Open Jdgilby opened 6 months ago

Jdgilby commented 6 months ago

I've gone through after editing the business logic Riverscapes/RiverscapesXML#715 and found that all layers are loaded into the viewer. However only one realization can be viewed at once. image image You can see in the first image the DCE group is brought in but the layers wont populate. I can remove the ones from the first DCE out of the layer tree and then the other DCE is allowed to populate, but both wont be populated in the layer tree.

This happens to every layer that has a repeat name from DCE to DCE, or even in one DCE if different layers have the same names (pour points, catchments, structural elements).

@KellyMWhitehead please advise if this is just something I wrote wrong in the business logic.

KellyMWhitehead commented 6 months ago

This is a bug in QViewer - a very old version of code we use to determine if a layer is already in the map. We have a much better system in place for QRiS.

I think the business logic is fine, and seems to work if you change the layer name in the layer tree.

Jdgilby commented 6 months ago

@KellyMWhitehead Is it a possibility to fix that in the Viewer? I can see changing the layer name in the tree not being an intuitive fix for the average user viewing data through the viewer.

KellyMWhitehead commented 6 months ago

@Jdgilby yes, I meant to say I will make the fix in the viewer.