search

Riverscapes / riverscapes-tools

Open-source Python 3.0 tools for the Riverscapes organization
https://tools.riverscapes.net/
GNU General Public License v3.0
11 stars 11 forks source link

Should we add (and expose in Business Logic) a New Model Extent Layer #757

Open joewheaton opened 1 year ago

joewheaton commented 1 year ago

As I am seeing ramifications of our switch from HUC 8 to 10 and thinking about custom extent runs and running in different places, I'm wondering if we can and should add a new layer to expose in Viewer to ALL our production grade projects of project extent. It is now something you include in a geoJSON if I'm not mistaken as part of project.rs.xml. What would it take to add it? It would be really useful for confirming (not just assuming) that I know what was the Model Extent and in case of RS_Context clear up things that are clearly outside it for other reasons.

Thoughts @MattReimer, @jtgilbert and @philipbaileynar ?

MattReimer commented 1 year ago

Not a bad idea but I'd need to think about it. This might be more a feature of the RV product than belonging in a BL file.

Also it's optional so we can't depend on it being there.

Maybe we could have a special item that automatically adds itself to every tree if the project extent is present and a function to add this to the map and symbolize it....

philipbaileynar commented 1 year ago

Lots of noise around WebRAVE extents... I think most of it goes away if we fix two problems:

  1. Initial map extent - @MattReimer said that he was going to fix WebRAVE so that it initializes the map with the extent of the layers in the map - not the entire project.
  2. Zoom to layer extent (expand icon to the right of the layer in the map ToC) - this just doesn't work.

Let's try to fix these two issues without changing anything about the projects, additional data etc.

MattReimer commented 1 year ago

I think those are good points @philipbaileynar but I also think there is something to this feature request, even on top of that. We may not get to it in this phase but let's leave it open so we can circle back and talk about it.

Just for reference. Those tickets

philipbaileynar commented 9 months ago

The bounds extent is a valid GeoJSON file that can be included in business logic. I don't we need a new ShapeFile or GeoPackage layer.

philipbaileynar commented 3 months ago

Given that the bounds GeoJSON is already referenced in the project.rs.xml and therefore usable by all our viewers (if it exists), I propose that there are no changes needed to our models and therefore bump this to the milestone following the upcoming big re-run.