RobertBiehl / caffe2-ios

☕️ Caffe2Kit. A simple one step integration of Caffe2 for iOS.
Apache License 2.0
71 stars 13 forks source link

Fix build scripts and podspec #10

Closed danielhauagge closed 5 years ago

danielhauagge commented 7 years ago
RobertBiehl commented 7 years ago

Hi Daniel,

Thanks for the PR. I’ll review it in the morning!

Rob

On 14 Jul 2017, at 00:16, Daniel Hauagge notifications@github.com wrote:

In the build_all.sh script I uncommented some of the make install commands In the build_ios_pod.sh script I changed the logic for setting USE_NNPACK. The old logic was failing when IOS_PLATFORM was defined outside of build_ios_pod.sh The changes in the podspec file fixed issues I was having when using this as a local pod (incorrect header search paths) You can view, comment on, or merge this pull request online at:

https://github.com/RobertBiehl/caffe2-ios/pull/10

Commit Summary

Fixes to build script Fixes to podspec cleanup File Changes

M Caffe2Kit.podspec (12) M scripts/build_all.sh (27) M scripts/build_ios_pod.sh (5) Patch Links:

https://github.com/RobertBiehl/caffe2-ios/pull/10.patch https://github.com/RobertBiehl/caffe2-ios/pull/10.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.