search

RobertBiehl / caffe2-ios

☕️ Caffe2Kit. A simple one step integration of Caffe2 for iOS.
Apache License 2.0
71 stars 13 forks source link

Swifty interface changes and minor API improvements #4

Closed abjurato closed 7 years ago

abjurato commented 7 years ago
  1. swift3 conventions naming in header
  2. init() not exposed
  3. throwing initializer throws if pb files with requested names are not found in bundle
  4. deallocator closing protobuf
RobertBiehl commented 7 years ago

@abjurato Thanks for the PR. I'm just working on another fix that ensures that the color space is always correct (currently different UIImages have different color space layouts).

After that I'll create a release!

abjurato commented 7 years ago

Don't you consider moving wrapper part to caffe2's repo, as described by @bwasti (https://github.com/caffe2/caffe2/issues/298#issuecomment-297461497)? IMO it would be easier to maintain there, closer to C++ code, wider community

RobertBiehl commented 7 years ago

I think it makes sense to move it over once it's good enough. The Caffe2 repo ist already full of half baked stuff in my opinion.

On 26. Apr 2017, at 20:15, Anatoly Rosencrantz notifications@github.com wrote:

Don't you consider moving wrapper part to caffe2's repo, as described by @bwasti https://github.com/bwasti (caffe2/caffe2#298 (comment) https://github.com/caffe2/caffe2/issues/298#issuecomment-297461497)? IMO it would be easier to maintain there, closer to C++ code, wider community

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/RobertBiehl/caffe2-ios/pull/4#issuecomment-297496811, or mute the thread https://github.com/notifications/unsubscribe-auth/AAbQm5IyMAEZI0twfDNRnp16UqdNB2tPks5rz4nbgaJpZM4NJK7X.