search

RobertD502 / home-assistant-flair

Custom component for Home Assistant Core for Flair pucks, vents, rooms, structures, and minisplits
MIT License
87 stars 12 forks source link

Plugin fails to register if user has no vents #4

Closed shauntarves closed 2 years ago

shauntarves commented 2 years ago

I submitted a PR in the https://github.com/RobertD502/hass-flair-helper project to handle an exception that's thrown when I try to configure this.

I don't have any vents, but I do have some pucks that I want to use. The entire config flow fails because the EmptyBodyException bubbles up to hass.

RobertD502 commented 2 years ago

Have you tested this out? I won't be able to since I do have vents.

Edit: In the manifest.json file, replace "hass-flair-helper==0.0.6.2" with "git+https://github.com/RobertD502/hass-flair-helper@main#hass-flair-helper==0.0.6.3" and reboot HA to test out your hass-flair-helper PR that I just merged.

shauntarves commented 2 years ago

Hey @RobertD502,

That solution worked for me. The only thing I noticed was this message that seems to be missing some content

Screen Shot 2021-07-23 at 12 37 34 PM

RobertD502 commented 2 years ago

I know exactly what is causing that. Will fix it once I'm back at the computer.

RobertD502 commented 2 years ago

@shauntarves Just fixed it. Will create a new release as soon as I publish the hass-flair-helper changes to PyPi. Once the new release is out, update through HACS, then delete the integration (from the config --> integrations menu) , reboot, and add the integration again through the config --> integrations menu. The integration should display the title "Flair" on the integrations page as well as show "Flair" in the prompt that follows the initial setup.

shauntarves commented 2 years ago

Hey @RobertD502 did you get this release done? I'm not seeing it.

RobertD502 commented 2 years ago

Just pushed it to PyPi. I've been away from my main Mac where my PyPi key is. Sorry for the delay! Will be pushing out the HA updates as well in a bit.

RobertD502 commented 2 years ago

Hey @shauntarves do you happen to be using your puck(s) to control any mini-splits?

shauntarves commented 2 years ago

@RobertD502 sure am...I was hoping to add that functionality to this plugin.

RobertD502 commented 2 years ago

Do you have another preferred place of contact besides github?

shauntarves commented 2 years ago

Sure.. hit me on email and we can go from there.

On Mon, Jul 26, 2021 at 2:47 PM RobertD502 @.***> wrote:

Do you have another preferred place of contact besides github?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/RobertD502/home-assistant-flair/issues/4#issuecomment-886941196, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABEDBMDSP3VSPTACQRXRCGLTZWUSPANCNFSM5A2YXTWQ .