search

RobertDober / earmark_parser

The Markdown to AST part of Earmark.
Apache License 2.0
68 stars 26 forks source link

Resolve single quote string warnings #152

Closed kianmeng closed 5 months ago

kianmeng commented 5 months ago

This resolves the following errors during tests:

warning: single-quoted strings represent charlists. Use ~c"" if you
indeed want a charlist or use "" instead
RobertDober commented 5 months ago

Thank you for this one too. Would you have any idea why the GHA did not catch this? I have enabled the appropiate switches I guess, maybe I made a typo there too :blush:

I will try to make a release tomorrow I hate to create warnings for ex_doc and all dependents.

kianmeng commented 5 months ago

Would you have any idea why the GHA did not catch this? I have enabled the appropiate switches I guess, maybe I made a typo there too 😊

https://github.com/RobertDober/earmark_parser/blob/c19c0171bb86b73dbfccefac8d6e7e3a6fce3297/.github/workflows/elixir.yml#L56-L64

I believe we need to update line 61 to:

mix test --warnings-as-errors

Also, I have to force recompile again to just get it to throw error in my local dev:

mix test --force --warnings-as-errors
kianmeng commented 5 months ago

Thank you for this one too.

:partying_face: :partying_face: :partying_face: :partying_face: :partying_face:

RobertDober commented 4 months ago

I believe we need to update line 61 to: mix test --warnings-as-errors

hmm does not look like that, the current configuration seems to do the trick https://github.com/RobertDober/earmark_parser/actions/runs/9768021924/job/26964613065

Anyway I just checked the warnings will only occur in the tests so they will not show up in depending libraries, therefore I'll not release yet to avoid to much noise.

Thank you for your help