search

RobinCK / vue-gallery

:camera: Responsive and customizable image and video gallery, carousel and lightbox, optimized for both mobile and desktop web browsers. 🇺🇦
https://robinck.github.io/vue-gallery/
MIT License
470 stars 85 forks source link

Data Description #12

Closed renatodolza closed 6 years ago

renatodolza commented 6 years ago

Hello everyone! I would like you to implement this improvement or explain how to do it, if there is one already.

https://github.com/blueimp/Gallery#additional-gallery-elements

cocoastorm commented 6 years ago

Hey @renatodolce,

I had to change a couple of things with a fork to add the description for each image.

Here's a JSFiddle to tinker with.

You can find the changes I made in update-description branch of my fork.

If you want (and once I have some time) I can make a PR and then @RobinCK can merge it in if he wants this.

renatodolza commented 6 years ago

@khoanguyen96 Thank you, it was excellent! Just take a doubt, have a delay in the slide exchange, know if you have how to take ?? look at the gif I made on top of your JSFiddle

vuegallerydescription

renatodolza commented 6 years ago

I was able to solve it, you were calling on the onslideend I changed it to call on the onslide only, then it worked. thank you ;-)

cocoastorm commented 6 years ago

Ah sorry that's my bad. My original intention was to call onslide, regardless I'm glad you figured it out!

Should I prep a PR? Or are you good for now?

Cheers!

renatodolza commented 6 years ago

No problem, good thing we found out 💪 Feel free to PR Hugs!