RoboJackets / robocup-software

Georgia Tech RoboJackets Software for the RoboCup Small Size League
Apache License 2.0
183 stars 187 forks source link

Fixed Collect path planner going into goal/red area when passing/stealing #2228

Closed jvogt23 closed 8 months ago

jvogt23 commented 8 months ago

Description

Describe your pull request. This PR is to merge changes that will fix an issue with the Collect path planner that causes it to go into the red areas of the field (enemy goal). Stealing or receiving robots should now switch to SEEKING if the ball is in the red area, and they will enter "escaping obstacle" if they are in the red areas

Associated / Resolved Issue

Resolves # or ClickUp card Resolves ClickUp 86ayq6wkp

Design Documents

Link

Steps to Test

Test Case 1: The ball rolls in then out of the enemy goal

  1. Step 1 Start a match and position the ball on one side of the enemy goal.
  2. Step 2 When a robot locks onto it, give it a velocity so it rolls through the red area, exiting somewhere still on the field
  3. Step 3 The robots should momentarily begin SEEKING and never enter the red, following the ball after it leaves the red.
  4. Step 4 Repeat all steps, except instead of rolling the ball through the red, leave it in the red. The robots should either stop or enter SEEKING without following the ball.

Expected result: See steps 3 and 4

Key Files to Review

Group 1 Planning

Group 2 Positions

Review Checklist

(Optional) Sub-issues (for drafts)

Note: if you find yourself breaking this PR into many smaller features, it may make sense to break up the PR into logical units based on these features.