search

RoboSherlock / robosherlock

http://www.robosherlock.org
26 stars 28 forks source link

Update PointCloudCLusterExtractor.cpp for ROS noetic version #220

Closed abmuslim closed 3 years ago

Sanic commented 3 years ago

Hi @abmuslim ! Thanks for the PR. I'm not sure if my notification settings are correct here. So it would be nice if you could ping/mention me when you've checked the comments on the review above. Thanks in advance.

Sanic commented 3 years ago

Thanks. Can you please commit the requested changes to your noetic-dev branch on your fork?

abmuslim commented 3 years ago

I did it. please check.

Sanic commented 3 years ago

Hm, it looks like the requested changes still are not in this PR?

abmuslim commented 3 years ago

@Sanic Please check the update PointCLoudClusterExtractor.cpp below for changes.

Sanic commented 3 years ago

Thanks! Looks good now 👍