Open JackMostow opened 3 years ago
This might be a bug in mcq.json, but a repeated choice should disqualify a cloze question.
Options: a. "Eliminate all spindles in the kingdom": Off-line eliminate all overlapping choices in mcq.json. +: fairly straightforward -: requires parsing mcq.json -: requires specifying which category of choice to eliminate when the same choice appears in >1 category -: specific to mcq.json
b. "Inoculate the princess": Runtime constrain selection of distractors to exclude choices so far +: complicates the code
c. "vaccine to cover variants": Check all multiple choice questions and skip them if any choice (including target) is repeated. --> DO THIS IF FEASIBLE +: simpler code, e.g. try-catch-throw -: may skip questions that a more sophisticated solution could salvage -: must fire at right point in code, e.g. can't skip page of story
https://github.com/RoboTutorLLC/RoboTutor_2020/tree/cloze_issue
I have worked a little in this branch, but it has the infinite loop possibility
@mmh - Use this issue to see how the animator graph interacts with the Java component for mcq; sentence prediction is similar. Make sure the distractor differs from the correct sentence.
Sushant in meeting notes: Thought a little upon the cloze question, found "CLOZEPAGEFLIP" (has been commented though) in story_questions/animator_graph.json, which might be helping us to skip a cloze question if multiple options match each other. What it would take: Animator graph first call method to retrieve question from mcq.json and store it Check for repeated choices in src/main/java/cmu/xprize/comp_questions/CQn_ViewManagerASB.java and set FTR to skip cloze question (--> CLOZEPAGEFLIP?) If survive check, retrieve stored question and present it as at present
Describe the bug The same distractor (kazi?) showed up as choices 2 and 4 in the same cloze question on page 2 of story 35.
To Reproduce Steps to reproduce the behavior:
Expected behavior A cloze question with 4 distinct choices.
Actual behavior A cloze question with once of the choices listed 2x.
Screenshots If applicable, add screenshots to help explain your problem.
Additional details