install: Do not install Bazel-generated python scripts

RobotLocomotion / drake

Model-based design and verification for robotics.

https://drake.mit.edu

Other

3.35k stars 1.27k forks source link

install: Do not install Bazel-generated python scripts #11303

Closed EricCousineau-TRI closed 2 years ago

EricCousineau-TRI commented 5 years ago

Installing these scripts is worse than useless, it's harmful.

Lost time to this here: https://github.com/robotlocomotion/drake/pull/11261#issuecomment-485510181

jamiesnape commented 5 years ago

They didn't used to be; we create different launchers, where necessary. Did something change?

EricCousineau-TRI commented 5 years ago

Yeah, just that I had decided to install scripts under pydrake.examples, and didn't think to scrub the Bazel-generated stuff. #11304 seems simple enough to fix that mistake

jwnimmer-tri commented 4 years ago

For the record, these appear to be the installed stubs, as of Drake v0.17.0.

drake/lib/python3.6/site-packages/pydrake/examples/multibody/pendulum_lqr_monte_carlo_analysis
drake/lib/python3.6/site-packages/pydrake/examples/multibody/cart_pole_passive_simulation
drake/lib/python3.6/site-packages/pydrake/examples/multibody/run_planar_scenegraph_visualizer

EricCousineau-TRI commented 4 years ago

Just curious, can post your recipe used to generate that list?

jwnimmer-tri commented 4 years ago

I grepped the v0.17.0 binary release for 'env python$'.

jwnimmer-tri commented 2 years ago

The new grep is for 'env python3$'. As of v0.39.0, the list of problematic files remains only the same three as above.