RobotWebTools / rclnodejs

Node.js version of ROS 2.0 client
https://docs.ros.org/en/humble/Concepts/Basic/About-Client-Libraries.html?highlight=rclnodejs#community-maintained
Apache License 2.0
311 stars 70 forks source link

Adds msg generation support for workspace overlays #904

Closed wayneparrott closed 1 year ago

wayneparrott commented 1 year ago

Revises the message_generation process as follows:

  1. recursively delete the generated/ folder before generating new message files
  2. process the AMENT_PREFIX_PATH in reverse order such that interfaces defined earlier on the AMENT_PREFIX_PATH will overwrite older versions of the interface. Thus interfaces defined in a ROS overlay workspace take precedent over a version of the interface defined in an underlay.

Additional mods were made to help address a stability issue involving content-filters in CI:

Fix #902

wayneparrott commented 1 year ago

@minggangw Thx for the review.

minggangw commented 1 year ago

Thanks @wayneparrott , I'm going to merge this PR!