Closed maciejmajek closed 5 days ago
@coderabbit full review
The changes in this pull request focus on the initialize_ros_nodes
function within the src/rai_hmi/rai_hmi/ros.py
file. The main modification involves the initialization of the whitelist
variable. If the ros2_whitelist
argument is not provided, the whitelist
is now set to None
instead of an empty list. This change impacts how the whitelist
is subsequently utilized, particularly in its interaction with the RaiBaseNode
constructor.
File Path | Change Summary |
---|---|
src/rai_hmi/rai_hmi/ros.py | Modified initialize_ros_nodes to assign whitelist as None if ros2_whitelist is not provided. |
sequenceDiagram
participant User
participant ROS
participant RaiBaseNode
User->>ROS: Call initialize_ros_nodes(ros2_whitelist)
alt ros2_whitelist provided
ROS->>RaiBaseNode: Initialize with whitelist
else ros2_whitelist not provided
ROS->>RaiBaseNode: Initialize with whitelist = None
end
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Purpose
The initialization process of text_hmi was flawed due to bad whitelist handling.
Proposed Changes
Properly initializes empty whitelist
Issues
Testing
Summary by CodeRabbit
ros2_whitelist
is not provided.